[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support
|
From: |
Kevin Wolf |
|
Subject: |
[Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support |
|
Date: |
Thu, 31 Mar 2011 13:38:50 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 31.03.2011 13:15, schrieb Jes Sorensen:
> On 03/31/11 12:38, Kevin Wolf wrote:
>> Am 30.03.2011 14:16, schrieb address@hidden:
>>> From: Jes Sorensen <address@hidden>
>>>
>>> This adds the basic infrastructure for supporting progress output
>>> on the command line, as well as progress support for qemu-img commands
>>> 'rebase' and 'convert'.
>>>
>>> Signed-off-by: Jes Sorensen <address@hidden>
>>
>> Thanks, applied to the block branch.
>>
>> I think we should consider turning the progress output on by default if
>> qemu-img is run from a terminal.
>
> Thanks!
>
> I have been a little reluctant to do this because it will break the ABI
> for tools running qemu-img from a GUI etc.
That's the reason for the "from a terminal" part. If we check for
isatty(), we should handle these cases just fine.
Kevin