[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC] vga: flag vga ram for notifiers

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH RFC] vga: flag vga ram for notifiers
Date: Thu, 31 Mar 2011 15:21:02 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8

On 03/31/2011 03:03 PM, Michael S. Tsirkin wrote:
On Thu, Mar 31, 2011 at 02:26:59PM -0500, Anthony Liguori wrote:
On 03/31/2011 02:07 PM, Michael S. Tsirkin wrote:
Just needs some love.

VGA is just another device.  It happens to be that we treat VGA
device memory as something that behaves like ram occassionally but
that does not make it RAM.
If we agree on that, will a pair of functions for this work?
How about device_register_ram / device_unregister_ram ?
To register normal RAM or to register stuff that isn't RAM but looks
and tastes like RAM?
The later.

If you're going to take that approach (and I'd strongly advise you to reconsider :-)), I'd at least suggest making the name a bit clearer. For instance, device_shadow_memory_as_ram() or something along those lines.


Anthony Liguori

Something like vhost doesn't need to see anything but RAM.  If we
have a mechanism to identify RAM as RAM, then vhost can only look at
RAM memory and not worry about things like VGA.

I thought Alex had gotten a mini-version of RamAPI in but I can't
seem to figure out what that included.
Me neither.

  At any rate, the point is
still that registering things that you want to exclude in vhost is
the wrong approach, you want to explicitly mark the things you want
to include.


Anthony Liguori
vhost just wants RAM.
Right, so mark RAM, and call it a day :-)


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]