[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing supp
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support |
Date: |
Fri, 01 Apr 2011 15:41:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 |
On 03/31/11 13:49, Stefan Hajnoczi wrote:
> On Thu, Mar 31, 2011 at 12:38 PM, Kevin Wolf <address@hidden> wrote:
>> Am 31.03.2011 13:15, schrieb Jes Sorensen:
>>> On 03/31/11 12:38, Kevin Wolf wrote:
>>> I have been a little reluctant to do this because it will break the ABI
>>> for tools running qemu-img from a GUI etc.
>>
>> That's the reason for the "from a terminal" part. If we check for
>> isatty(), we should handle these cases just fine.
>
> Yes, I think checking for a tty is enough precaution and allows users
> to get the benefit of the progress bar. TBH I'd probably forget to
> add -p half the time :).
Ok, this is fine with me - however how do you suggest we offer the
option to disable it on the command line, an additional flag?
Jes
- Re: [Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support,
Jes Sorensen <=