[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail |
Date: |
Fri, 1 Apr 2011 16:59:44 +0100 |
On Fri, Apr 1, 2011 at 4:52 PM, Peter Maydell <address@hidden> wrote:
> On 1 April 2011 16:20, Michael Roth <address@hidden> wrote:
>> We also make C99 //comments a warning instead of an error, since they
>> don't actually violate QEMU's coding guidelines.
>
> We should either update the guidelines or fix the script...
There are a whole bunch of // in the codebase. I prefer /* */ but as
it stands I think // should not even raise a warning.
Stefan
- [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Michael Roth, 2011/04/01
- [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error, Michael Roth, 2011/04/01
- [Qemu-devel] [PATCH 1/2] checkpatch.pl: add --no-fail-on-warn option, Michael Roth, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Peter Maydell, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail,
Stefan Hajnoczi <=
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Peter Maydell, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Michael Roth, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Peter Maydell, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Michael Roth, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Stefan Hajnoczi, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Michael Roth, 2011/04/01
- Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail, Stefan Hajnoczi, 2011/04/02