[Qemu-devel] Re: [PATCH] tests/cris: Fix some errors and potential crashes

[Edgar E. Iglesias]

On Sun, Apr 03, 2011 at 09:36:36PM +0200, Stefan Weil wrote:
> These errors were reported by cppcheck:
> 
> tests/cris/check_openpf1.c:30: error:
> Mismatching allocation and deallocation: f
> 
> tests/cris/check_openpf2.c:13: error:
> Mismatching allocation and deallocation: f
> 
> tests/cris/check_stat3.c:16: error:
> Buffer overrun possible for long cmd-line args
> 
> tests/cris/check_stat4.c:18: error:
> Buffer overrun possible for long cmd-line args
> 
> The first two are obvious coding errors (fopen needs fclose, not close).
> 
> The last two may seem less important (nobody will start test code
> with an argument of more than 1022 characters which raises a buffer
> overrun). Fixing them nevertheless helps with static code checks
> like those done by cppcheck.

Thanks, I've applied this.

Cheers