qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] spapr_vscsi: Set uninitialized variable


From: Alexander Graf
Subject: [Qemu-devel] Re: [PATCH] spapr_vscsi: Set uninitialized variable
Date: Mon, 04 Apr 2011 17:03:44 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7

On 04/03/2011 06:21 PM, Stefan Weil wrote:
cppcheck reports this error:

hw/spapr_vscsi.c:274: error: Uninitialized variable: rc

If llen == 0, rc was indeed used without being initialized.

Signed-off-by: Stefan Weil<address@hidden>
---
  hw/spapr_vscsi.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/spapr_vscsi.c b/hw/spapr_vscsi.c
index e142dae..9928334 100644
--- a/hw/spapr_vscsi.c
+++ b/hw/spapr_vscsi.c
@@ -255,7 +255,7 @@ static int vscsi_srp_direct_data(VSCSIState *s, vscsi_req 
*req,
  {
      struct srp_direct_buf *md = req->cur_desc;
      uint32_t llen;
-    int rc;
+    int rc = 0;

David, is this correct? Or would rc be -1 when !llen?


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]