[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during
From: |
Brad Hards |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration |
Date: |
Thu, 7 Apr 2011 15:39:04 +1000 |
User-agent: |
KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.5.1; x86_64; ; ) |
On Thu, 7 Apr 2011 06:41:35 am Michael S. Tsirkin wrote:
> As a solution, this adds an explicit flag that
> will enable dirty logging directly when registering
> the ram. kvm then needs a single system call
> to update tables for vga ram, vhost-net can simply ignore it.
I'm not very familiar with QEMU coding style and standards (so this could be
completely bogus), but I think that the code would be easier if you used a
integer flag / enum instead of a boolean. That would also give you options for
additional behaviour changes later too. So instead of passing true/false, pass
MEM_LOG_DIRTY_PAGES (or whatever you decide to call it).
I can't really comment on the rest of the patch - I'm too clueless.
> This replaces the RFC patchset 'vga: flag vga ram for notifiers'.
> Warning: compile-tested only.
I compiled and booted my Ubuntu guest (on ubuntu host) which uses Cirrus for
each step in this patchset. Seems OK to me - I didn't notice appreciable
speedup, but I wasn't really expecting to.
Brad
- [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 1/5] cpu: add set_memory flag to request dirty logging, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 5/5] cirrus_vga: flag on-device ram for dirty logging, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 4/5] vhost: optimize out no-change assignment, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 2/5] kvm: halve number of set memory calls for vga, Michael S. Tsirkin, 2011/04/06
- [Qemu-devel] [PATCH RFC 3/5] vhost: skip memory which needs dirty logging, Michael S. Tsirkin, 2011/04/06
- Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration,
Brad Hards <=