qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v3 0/2] Correct transitions for cd change state


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH v3 0/2] Correct transitions for cd change state
Date: Thu, 07 Apr 2011 11:26:52 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 04/07/2011 10:46 AM, Amit Shah wrote:
Hello,

These two patches fix the cd media size change bugs.

The test scenario is:

1. create an iso image from a file
2. create a second iso image from a bigger file
3. mount 1st cd in guest
4. unmount it
5. change cd via qemu monitor
6. mount 2nd cd
7. copy file on cd to local disk -- shows errors.

v2: Set media_change_notified to 1 if SENSE_UNIT_ATTENTION is not set
after migration.  This is the only thing needed for migration compat.

v3:
  - Use cdrom_changed to hold all state changes instead of introducing
    a new variable. (Paolo Bonzini)
  - Slightly better comment and commit messages

Please apply.

Amit Shah (2):
   cdrom: Allow the TEST_UNIT_READY command after a cdrom change
   cdrom: Make disc change event visible to guests

  hw/ide/core.c |   56 +++++++++++++++++++++++++++++++++++++++++++++++---------
  1 files changed, 47 insertions(+), 9 deletions(-)


Thanks!

Reviewed-by: Paolo Bonzini <address@hidden>

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]