[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] target-ppc: remove #ifdef FLOAT128
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] Re: [PATCH] target-ppc: remove #ifdef FLOAT128 |
Date: |
Sun, 10 Apr 2011 23:14:41 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Sun, Apr 10, 2011 at 09:08:55PM +0100, Peter Maydell wrote:
> On 10 April 2011 20:23, Alexander Graf <address@hidden> wrote:
> > On 10.04.2011, at 21:12, Aurelien Jarno wrote:
> >> Now that PPC defaults to softfloat which always provides float128
> >> support, there is no need to keep two version of the code, depending if
> >> float128 support is available or not. Suggested by Peter Maydell.
>
> > Looks good to me, but I'd leave this to Peter's ack.
>
> I think it's a sensible (and pretty straightforward) cleanup, yes.
> [my bias towards emulation-accuracy means I don't really see
> much place for softfloat-native in a tcg qemu target, so I have
> no compunction about dropping support for it. :-)]
It seems that also what people want. We regularly got complain about
FP emulation precision (at least for the x86 target), but I don't
remember someone complaining about the speed of the FP emulation.
> Reviewed-by: Peter Maydell <address@hidden>
>
Thanks for the review.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net