[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vfio: Add an ioctl to reset the device
From: |
Chris Wright |
Subject: |
Re: [Qemu-devel] [PATCH] vfio: Add an ioctl to reset the device |
Date: |
Tue, 19 Apr 2011 15:37:03 -0700 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Alex Williamson (address@hidden) wrote:
> On Tue, 2011-04-19 at 15:26 -0700, Chris Wright wrote:
> > * Alex Williamson (address@hidden) wrote:
> > > On Tue, 2011-04-19 at 15:07 -0700, Chris Wright wrote:
> > > > * Alex Williamson (address@hidden) wrote:
> > > > > When using VFIO to assign a device to a guest, we want to make sure
> > > > > the device is quiesced on VM reset to stop all DMA within the guest
> > > > > mapped memory. Add an ioctl which just calls pci_reset_function()
> > > > > and returns whether it succeeds.
> > > >
> > > > Shouldn't there be a reset when binding/unbinding vfio to/from a pci
> > > > device?
> > >
> > > There's already one when the /dev/vfioX file is opened, we should add
> > > another on release, and probably add the same PCI save state store/load
> > > that I'm proposing for KVM across those. Thanks,
> >
> > Hmm, I looked and didn't see it, hence the question.
>
> vfio_open() -> pci_reset_function()
> https://github.com/pugs/vfio-linux-2.6/blob/vfio/drivers/vfio/vfio_main.c
Got it, thanks Alex.
Re: [Qemu-devel] [PATCH] vfio: Add an ioctl to reset the device, Tom Lyon, 2011/04/19