[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/20] softfloat-native: add float*_is_any_nan()
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 09/20] softfloat-native: add float*_is_any_nan() functions |
Date: |
Wed, 20 Apr 2011 11:22:49 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Apr 19, 2011 at 01:42:00PM +0100, Peter Maydell wrote:
> On 18 April 2011 22:00, Aurelien Jarno <address@hidden> wrote:
>
> > @@ -511,4 +530,11 @@ int floatx80_is_quiet_nan( floatx80 a1 )
> > return ( ( u.i.high & 0x7FFF ) == 0x7FFF ) && (uint64_t) ( u.i.low<<1 );
> > }
> >
> > +int floatx80_is_any_nan( floatx80 a1 )
> > +{
> > + floatx80u u;
> > + u.f = a1;
> > + return ((u.i.high & 0x7FFF) == 0x7FFF) && ( u.i.low<<1 );
> > +}
> > +
> > #endif
>
> As you can just see from the context, the new function is
> actually identical to the existing floatx80_is_quiet_nan(),
> but the latter is wrong, not this patch :-)
>
> Nobody seems to use floatx80_is_quiet_nan() so if we're just
> going to nuke softfloat-native shortly there's no point fixing
> it I guess.
>
IIRC, we already discovered that when changing the name of the nan()
functions. I also don't plan to fix it, it's one more reason to kill
softfloat-native.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- Re: [Qemu-devel] [PATCH 17/20] target-i386: fix logarithmic and trigonometric helpers wrt softfloat, (continued)
- [Qemu-devel] [PATCH 13/20] target-i386: fix helper_fdiv() wrt softfloat, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 15/20] target-i386: replace approx_rsqrt and approx_rcp by softfloat ops, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 10/20] target-i386: fix helper_fscale() wrt softfloat, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 09/20] softfloat-native: add float*_is_any_nan() functions, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 20/20] target-i386: switch to softfloat, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 19/20] target-i386: fix constants wrt softfloat, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 14/20] target-i386: fix helper_fsqrt() wrt softfloat, Aurelien Jarno, 2011/04/18
- [Qemu-devel] [PATCH 18/20] target-i386: fix helper_fprem() and helper_fprem1() wrt softfloat, Aurelien Jarno, 2011/04/18