[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync. |
Date: |
Thu, 28 Apr 2011 14:45:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9 |
On 04/27/11 17:05, Jes Sorensen wrote:
> On 04/27/11 17:05, Luiz Capitulino wrote:
>> On Mon, 18 Apr 2011 16:27:01 +0200
>> address@hidden wrote:
>>
>>> From: Jes Sorensen <address@hidden>
>>>
>>> This is quivalent to snapshot_blkdev in the human monitor, with _sync
>>> added to the command name to make it explicit that the command is
>>> synchronous and leave space for a future async version.
>>
>> I'm not sure appending "_sync" is such a good convention, most commands
>> are sync today and they don't have it. I'd prefer to call it snapshot_blkdev
>> and note in the documentation how it works.
>>
>> On the other hand, I'm not sure how Anthony is going to model async
>> commands, so maybe he has a better suggestion.
>
> The _sync prefix is on purpose to leave space for a possible async
> implementation of the snapshot command in the future. This isn't related
> to it being a sync vs async qmp command though.
If people are more comfortable with the QMP command being
"blockdev-snapshot" and then using {-,_}async for the async comment in
the monitor and QMP later, that is fine with me.
I'd just like to move on this and get it upstream.
Cheers,
Jes
- [Qemu-devel] [PATCH v2 0/1] Add QMP bits for blockdev-snapshot-sync., Jes . Sorensen, 2011/04/18
- [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Jes . Sorensen, 2011/04/18
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Luiz Capitulino, 2011/04/27
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Jes Sorensen, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Jes Sorensen, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Kevin Wolf, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Jes Sorensen, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Kevin Wolf, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Jes Sorensen, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Luiz Capitulino, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Jes Sorensen, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Anthony Liguori, 2011/04/28
- Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync., Anthony Liguori, 2011/04/28