[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] debug logging
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] debug logging |
Date: |
Mon, 02 May 2011 13:00:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Jan Kiszka <address@hidden> writes:
> On 2011-05-02 12:33, Alon Levy wrote:
>> On Mon, May 02, 2011 at 12:25:30PM +0200, Gerd Hoffmann wrote:
>>> Hi,
>>>
>>>> dbg_print takes care of making it standard to have a loglevel and prefix,
>>>> sounds
>>>> good, but I'd still like to know if it is acceptable to also redirect with
>>>> -debug,
>>>> I guess reusing the DeviceState then, instead of my added struct, so just
>>>> letting
>>>> DeviceState.debug_chardev == NULL by default, and settable with
>>>> -debug<devname>,id=<chardev_id>
>>>
>>> Making dbg_print use DeviceState.debug_chardev (if present, stderr
>>> otherwise) looks sane to me. Buf I'd use standard properties then
>>> to set it instead of a separate -debug switch, i.e.
>>>
>>> -chardev file,id=messages,path=... \
>>> -device foo,dbg=1,dbglog=messages
>>>
>>
>> Sounds good. I'll try to make it so.
>
> We have a tracing infrastructure for such use cases today. Better invest
> in adding missing features there.
Start with docs/tracing.txt
- [Qemu-devel] debug logging (was: Re: [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs), Gerd Hoffmann, 2011/05/02
- Re: [Qemu-devel] debug logging (was: Re: [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs), Alon Levy, 2011/05/02
- Re: [Qemu-devel] debug logging, Gerd Hoffmann, 2011/05/02
- Re: [Qemu-devel] debug logging, Alon Levy, 2011/05/02
- Re: [Qemu-devel] debug logging, Jan Kiszka, 2011/05/02
- Re: [Qemu-devel] debug logging,
Markus Armbruster <=
- Re: [Qemu-devel] debug logging, Alon Levy, 2011/05/02
- Re: [Qemu-devel] debug logging, Jan Kiszka, 2011/05/02
- Re: [Qemu-devel] debug logging, Alon Levy, 2011/05/02
- Re: [Qemu-devel] debug logging, Paolo Bonzini, 2011/05/02