[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvm: ppc: detect old headers
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] kvm: ppc: detect old headers |
Date: |
Tue, 03 May 2011 15:02:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-05-03 14:33, Alexander Graf wrote:
>
> On 03.05.2011, at 14:31, Jan Kiszka wrote:
>
>> On 2011-05-03 14:28, Alexander Graf wrote:
>>>
>>> On 03.05.2011, at 14:14, Jan Kiszka wrote:
>>>
>>>> On 2011-05-03 13:54, Alexander Graf wrote:
>>>>> When compiling Qemu with older kernel headers, the PVR setting
>>>>> mechanism isn't available yet. Unfortunately, back then I didn't add
>>>>> a capability we could check against, so all we can do is add a configure
>>>>> test to see if we support PVR setting. For BookE, we don't care yet.
>>>>>
>>>>> This fixes compilation errors with KVM enabled on older kernel headers
>>>>> (like 2.6.32).
>>>>
>>>> Why not finally import the latest kvm kernel headers into qemu? Would
>>>> save us a lot of current and future configure and #ifdef dances.
>>>
>>> Sure, sounds like a good topic for today's call?
>>
>> Fine with me. Patch should be done by then as well.
>
> *shrug* I'm fairly indifferent on that topic. It would help users, so they
> can easier compile things, but requires us to keep the headers in sync. Do
> you have any good way of automating the process?
There will be a 'make update-kvm-headers' target, imported from
kvm-kmod. Can be run against some recent kernel, and the result will
just have to be committed & posted.
Moreover, I will drop alternative ways of pulling in headers (except via
CFLAGS overwriting). That will typically bite the patch submitter who
requires a header update and make her/him submit latest headers as well.
So far at least for the theory.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux