Re: [Qemu-devel] [PATCH 2/2] NBD: Convert the NBD driver to use the AIO interface.

[Nicholas Thomas]

On Thu, 2011-04-28 at 16:20 +0100, address@hidden wrote:

[...]

> +static void nbd_unregister_write_request_handler(BDRVNBDState *s)
> +{
> +    int sock = s->sock;
> +    if (s->sock == -1) { 
> +        logout("Unregister write request handler tried when socket
closed\n");
> +        return;
> +    }
> +
> +    qemu_aio_set_fd_handler(s->sock, nbd_aio_read_response, NULL,
> +                            nbd_aio_flush_request, NULL, s);
> +}

Sorry, I've just realised that this bit of the patch actually causes a
compiler eror (since sock is never used). Last-minute dickering about to
get things to fit into 80 columns :/

If that's the only issue with the patch, I'd be amazed, so I'll leave
resubmitting until there's further feedback, if that's OK?

/Nick