[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] PPC: Qdev'ify e500 pci
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] PPC: Qdev'ify e500 pci |
Date: |
Wed, 4 May 2011 22:08:48 +0300 |
On Mon, May 2, 2011 at 6:03 PM, Alexander Graf <address@hidden> wrote:
> The e500 PCI controller isn't qdev'ified yet. This leads to severe issues
> when running with -drive.
>
> To be able to use a virtio disk with an e500 VM, let's convert the PCI
> controller over to qdev.
>
> Signed-off-by: Alexander Graf <address@hidden>
>
> ---
>
> v2 -> v3:
>
> - rebase to current code base
> - fix endian issue
> - use sysbus helpers
> ---
> hw/ppce500_pci.c | 112
> +++++++++++++++++++++++++++++++++++-------------------
> 1 files changed, 73 insertions(+), 39 deletions(-)
>
> diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c
> index 83a20e4..88bc759 100644
> --- a/hw/ppce500_pci.c
> +++ b/hw/ppce500_pci.c
> @@ -73,11 +73,11 @@ struct pci_inbound {
> };
>
> struct PPCE500PCIState {
> + PCIHostState pci_state;
> struct pci_outbound pob[PPCE500_PCI_NR_POBS];
> struct pci_inbound pib[PPCE500_PCI_NR_PIBS];
> uint32_t gasket_time;
> - PCIHostState pci_state;
> - PCIDevice *pci_dev;
> + uint64_t base_addr;
This does not seem to be used. Also devices shouldn't care about their
base addresses.
- [Qemu-devel] [PATCH 0/6] PPC: Add FSL (e500) MMU emulation v3, Alexander Graf, 2011/05/02
- [Qemu-devel] [PATCH 2/6] PPC: Make MPC8544DS emulation work w/o KVM, Alexander Graf, 2011/05/02
- [Qemu-devel] [PATCH 1/6] PPC: Make MPC8544DS obey -cpu switch, Alexander Graf, 2011/05/02
- [Qemu-devel] [PATCH 3/6] PPC: Add GS MSR definition, Alexander Graf, 2011/05/02
- [Qemu-devel] [PATCH 6/6] PPC: Qdev'ify e500 pci, Alexander Graf, 2011/05/02
- Re: [Qemu-devel] [PATCH 6/6] PPC: Qdev'ify e500 pci,
Blue Swirl <=
- [Qemu-devel] [PATCH 5/6] PPC: Implement e500 (FSL) MMU, Alexander Graf, 2011/05/02
[Qemu-devel] [PATCH 4/6] PPC: Add another 64 bits to instruction feature mask, Alexander Graf, 2011/05/02
Re: [Qemu-devel] [PATCH 0/6] PPC: Add FSL (e500) MMU emulation v3, Blue Swirl, 2011/05/04