[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci |
Date: |
Sun, 8 May 2011 00:48:33 +0100 |
User-agent: |
KMail/1.13.5 (Linux/2.6.38-2-amd64; KDE/4.4.5; x86_64; ; ) |
> @@ -250,7 +254,6 @@ static const VMStateDescription vmstate_ppce500_pci = {
>
> .minimum_version_id = 1,
> .minimum_version_id_old = 1,
> .fields = (VMStateField[]) {
>
> - VMSTATE_PCI_DEVICE_POINTER(pci_dev, PPCE500PCIState),
Doesn't this require incrementing version_id?
> + vmstate_register(&dev->qdev, ppce500_pci_id++, &vmstate_ppce500_pci,
ppce500_pci_id is bogus, and should be removed.
You probably shouldn't be calling this at all. Instead use
sysbus_register_withprop and qdev.vmsd.
Other than that, this patch looks ok.
Paul
- [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v5, Alexander Graf, 2011/05/07
- [Qemu-devel] [PATCH 1/7] PPC: Make MPC8544DS obey -cpu switch, Alexander Graf, 2011/05/07
- [Qemu-devel] [PATCH 3/7] PPC: Add GS MSR definition, Alexander Graf, 2011/05/07
- [Qemu-devel] [PATCH 2/7] PPC: Make MPC8544DS emulation work w/o KVM, Alexander Graf, 2011/05/07
- [Qemu-devel] [PATCH 6/7] PPC MPC7544DS: Use new TLB helper function, Alexander Graf, 2011/05/07
- [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci, Alexander Graf, 2011/05/07
- Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci,
Paul Brook <=
- [Qemu-devel] [PATCH 4/7] PPC: Add another 64 bits to instruction feature mask, Alexander Graf, 2011/05/07
- [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU, Alexander Graf, 2011/05/07