[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Add an isa device for SGA
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2] Add an isa device for SGA |
Date: |
Fri, 13 May 2011 10:43:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Glauber Costa <address@hidden> writes:
> This patch adds a dummy legacy ISA device whose responsibility is to
> deploy sgabios, an option rom for a serial graphics adapter.
> The proposal is that this device is always-on when -nographics,
> but can otherwise be enable in any setup when -device sga is used.
>
> [v2: suggestions on qdev by Markus ]
One more question: should "-device sga" suppress the default VGA? The
other three VGA devices do; check out default_list[] in vl.c.
[...]
> diff --git a/hw/pc.h b/hw/pc.h
> index 1291e2d..a00e054 100644
> --- a/hw/pc.h
> +++ b/hw/pc.h
> @@ -219,6 +219,9 @@ int isa_vga_mm_init(target_phys_addr_t vram_base,
> void pci_cirrus_vga_init(PCIBus *bus);
> void isa_cirrus_vga_init(void);
>
> +/* serial graphics */
> +void isa_sga_init(void);
> +
No longer exists, please drop.
> /* ne2000.c */
> static inline bool isa_ne2000_init(int base, int irq, NICInfo *nd)
> {
[...]