[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [V2 04/25] [virtio-9p] clean up v9fs_readlink.
From: |
Venkateswararao Jujjuri (JV) |
Subject: |
[Qemu-devel] [V2 04/25] [virtio-9p] clean up v9fs_readlink. |
Date: |
Tue, 17 May 2011 12:43:30 -0700 |
Rearrange the code so that we can avoid V9fsReadLinkState.
Signed-off-by: Venkateswararao Jujjuri "<address@hidden>
---
hw/9pfs/virtio-9p.c | 25 ++++++++++---------------
hw/9pfs/virtio-9p.h | 7 -------
2 files changed, 10 insertions(+), 22 deletions(-)
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 06da2c9..e0e7eed 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -3586,35 +3586,30 @@ out:
static void v9fs_readlink(void *opaque)
{
V9fsPDU *pdu = opaque;
- V9fsState *s = pdu->s;
+ size_t offset = 7;
+ V9fsString target;
int32_t fid;
- V9fsReadLinkState *vs;
int err = 0;
V9fsFidState *fidp;
- vs = qemu_malloc(sizeof(*vs));
- vs->pdu = pdu;
- vs->offset = 7;
-
- pdu_unmarshal(vs->pdu, vs->offset, "d", &fid);
- fidp = lookup_fid(s, fid);
+ pdu_unmarshal(pdu, offset, "d", &fid);
+ fidp = lookup_fid(pdu->s, fid);
if (fidp == NULL) {
err = -ENOENT;
goto out;
}
- v9fs_string_init(&vs->target);
- err = v9fs_do_readlink(s, &fidp->path, &vs->target);
+ v9fs_string_init(&target);
+ err = v9fs_do_readlink(pdu->s, &fidp->path, &target);
if (err < 0) {
err = -errno;
goto out;
}
- vs->offset += pdu_marshal(vs->pdu, vs->offset, "s", &vs->target);
- err = vs->offset;
- v9fs_string_free(&vs->target);
+ offset += pdu_marshal(pdu, offset, "s", &target);
+ err = offset;
+ v9fs_string_free(&target);
out:
- complete_pdu(s, vs->pdu, err);
- qemu_free(vs);
+ complete_pdu(pdu->s, pdu, err);
}
static CoroutineEntry *pdu_co_handlers[] = {
diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h
index fb1e465..e95b63d 100644
--- a/hw/9pfs/virtio-9p.h
+++ b/hw/9pfs/virtio-9p.h
@@ -495,13 +495,6 @@ typedef struct V9fsGetlockState
V9fsGetlock *glock;
} V9fsGetlockState;
-typedef struct V9fsReadLinkState
-{
- V9fsPDU *pdu;
- size_t offset;
- V9fsString target;
-} V9fsReadLinkState;
-
size_t pdu_packunpack(void *addr, struct iovec *sg, int sg_count,
size_t offset, size_t size, int pack);
--
1.7.1
- [Qemu-devel] [V2 06/25] [virtio-9p] coroutines for readlink, (continued)
[Qemu-devel] [V2 02/25] [virtio-9p] Change all pdu handlers to coroutines., Venkateswararao Jujjuri (JV), 2011/05/17
[Qemu-devel] [V2 17/25] hw/9pfs: Add yield support to xattr related coroutine, Venkateswararao Jujjuri (JV), 2011/05/17
[Qemu-devel] [V2 22/25] [virtio-9p] coroutine and threading for mkdir, Venkateswararao Jujjuri (JV), 2011/05/17
[Qemu-devel] [V2 21/25] hw/9pfs: Update v9fs_mknod to use coroutines, Venkateswararao Jujjuri (JV), 2011/05/17
[Qemu-devel] [V2 04/25] [virtio-9p] clean up v9fs_readlink.,
Venkateswararao Jujjuri (JV) <=
[Qemu-devel] [V2 23/25] [virtio-9p] Remove post functions for v9fs_remove, Venkateswararao Jujjuri (JV), 2011/05/17
[Qemu-devel] [V2 20/25] hw/9pfs: Add yield support to mknod coroutine, Venkateswararao Jujjuri (JV), 2011/05/17
[Qemu-devel] [V2 01/25] [virtio-9p] Add infrastructure to support glib threads and coroutines., Venkateswararao Jujjuri (JV), 2011/05/17
[Qemu-devel] [V2 25/25] [virtio-9p] coroutine and threading for remove/unlink, Venkateswararao Jujjuri (JV), 2011/05/17
[Qemu-devel] [V2 24/25] [virtio-9p] clean up v9fs_remove., Venkateswararao Jujjuri (JV), 2011/05/17
Re: [Qemu-devel] [V2 0/25] Async threading for VirtFS using glib threads & coroutines., Stefan Hajnoczi, 2011/05/18