[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1][ 04/23] qerror: refactor error to make the h
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v1][ 04/23] qerror: refactor error to make the human message reusable |
|
Date: |
Wed, 18 May 2011 09:09:28 +0100 |
On Wed, May 18, 2011 at 1:51 AM, Michael Roth <address@hidden> wrote:
> +#if 0
> + qerror_abort(qerror, "expected '%c' in '%s'", c, entry->desc);
> +#else
> + fprintf(stderr, "expected '%c' in '%s'", c, entry->desc);
> abort();
> +#endif
There are a couple of #if 0 in the patch, please resolve them.
Stefan
- [Qemu-devel] [PATCH v1 00/23] QAPI Infrastructure Round 1, Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 02/23] error-propagation: base code for error propagation, Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 01/23] Add hard build dependency on glib, Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 04/23] qerror: refactor error to make the human message reusable, Michael Roth, 2011/05/17
- Re: [Qemu-devel] [PATCH v1][ 04/23] qerror: refactor error to make the human message reusable,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v1][ 05/23] qlist: add qlist_first()/qlist_next(), Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 03/23] error-propagation: build qemu with with error-propagation bits, Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 07/23] qapi: add ordereddict/qapi.py helper libraries, Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 06/23] qapi: add module init types for qapi, Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 08/23] qapi: add qapi-types.py code generator, Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 09/23] qapi: add qapi-visit.py code generator, Michael Roth, 2011/05/17
- [Qemu-devel] [PATCH v1][ 10/23] qapi: add qapi-commands.py code generator, Michael Roth, 2011/05/17