qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink


From: Venkateswararao Jujjuri
Subject: Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink
Date: Wed, 18 May 2011 11:28:19 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10

On 05/18/2011 02:31 AM, Stefan Hajnoczi wrote:
On Tue, May 17, 2011 at 8:43 PM, Venkateswararao Jujjuri (JV)
<address@hidden>  wrote:
Signed-off-by: Venkateswararao Jujjuri "<address@hidden>
---
  hw/9pfs/virtio-9p.c |   32 ++++++++++++++++----------------
  1 files changed, 16 insertions(+), 16 deletions(-)
Please see my comment from v1:
"The len argument is redundant and not used by any callers, please just
return -errno and drop the len argument.  Callers rely on buf->size
instead."
We took care of this while introducing coroutines in patch 6.
06/25 will modify functions for the new int v9fs_co_readlink(V9fsState *s, V9fsString *path, V9fsString *buf)

Thanks,
JV
Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]