[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props |
Date: |
Thu, 19 May 2011 16:05:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Amit Shah <address@hidden> writes:
> On (Thu) 19 May 2011 [13:37:16], Markus Armbruster wrote:
>> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
>> index bd3121e..a7d6b2b 100644
>> --- a/hw/virtio-serial-bus.c
>> +++ b/hw/virtio-serial-bus.c
>> @@ -642,6 +642,11 @@ static struct BusInfo virtser_bus_info = {
>> .name = "virtio-serial-bus",
>> .size = sizeof(VirtIOSerialBus),
>> .print_dev = virtser_bus_dev_print,
>> + .props = (Property[]) {
>> + DEFINE_PROP_UINT32("nr", VirtIOSerialPort, id,
>> VIRTIO_CONSOLE_BAD_ID),
>> + DEFINE_PROP_STRING("name", VirtIOSerialPort, name),
>> + DEFINE_PROP_END_OF_LIST()
>> + }
>
> 'name' isn't a must-have for all devices, but this is change OK.
The property is a must have, even though its value may remain null.
Correct?
[Qemu-devel] [PATCH 1/4] usb-ccid: Drop unused CCIDCardInfo callback print(), Markus Armbruster, 2011/05/19
Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users, Gerd Hoffmann, 2011/05/19