qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix
Date: Fri, 20 May 2011 17:55:50 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2011-05-20 17:49, Peter Maydell wrote:
> This patchset reverts commit f68b9d672, which was triggering
> spuriously for NICs created via -device rather than -net nic.
> It then reimplements the improved diagnostics with a different
> approach which only applies to '-net nic'. (It's only -net nic
> devices that can be ignored (ie not instantiated); -device
> nic devices are always instantiated. Checking for -device user
> errors like "this device wasn't plugged into any bus" is
> a separate issue not addressed here.)

But we still have the problem that qemu_new_nic does not call
net_init_nic. That means e.g. that NICs instantiated via -device don't
participate in automatic MAC assignment. Maybe fixing that makes this
series obsolete.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux



reply via email to

[Prev in Thread] Current Thread [Next in Thread]