|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps |
Date: | Fri, 20 May 2011 19:46:35 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 05/20/2011 05:53 PM, Christoph Hellwig wrote:
qbus_create_inplace(&bus->qbus,&scsi_bus_info, host, NULL); > bus->busnr = next_scsi_bus++; > bus->tcq = tcq; > bus->ndev = ndev; > - bus->complete = complete; > + bus->ops = *ops;Normally bus->ops would be a pointer, so you can just assign it to the address passed in instead of doing a copy. Any good reason to do it differently here?
I was thinking that they could be modified in-place later, or built on the stack depending on some qdev properties, but it's probably pointless to do it differently. Will change.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |