Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

[Paolo Bonzini]

On 05/26/2011 09:00 PM, Stefan Berger wrote:
> With the below patch I can build either ppc (-m32) or ppc64 (-m64)
> versions of Qemu (on a ppc64 host) when passing these compiler flags via
> 'configure ... --extra-cflags="-m32"'.
>
> Signed-off-by: Stefan Berger <address@hidden>
>
> ---
> configure | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> Index: qemu-git/configure
> ===================================================================
> --- qemu-git.orig/configure
> +++ qemu-git/configure
> @@ -807,7 +807,14 @@ case "$cpu" in
> arm*)
> host_guest_base="yes"
> ;;
> - ppc*)
> + ppc)
> + QEMU_CFLAGS="-m32 $QEMU_CFLAGS"
> + LDFLAGS="-m32 $LDFLAGS"
> + host_guest_base="yes"
> + ;;
> + ppc64)
> + QEMU_CFLAGS="-m64 $QEMU_CFLAGS"
> + LDFLAGS="-m64 $LDFLAGS"
> host_guest_base="yes"
> ;;
> mips*)

The patch doesn't seem to match the description.  I would have guessed 
that with this patch you _do not_ need to pass these compiler flags via 
--extra-cflags anymore.

Also, -m32/-m64 are really CPPFLAGS, not CFLAGS since they affect also 
the compiler's include path.

Paolo