[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 00/13] AMD IOMMU emulation patches, another
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC PATCH 00/13] AMD IOMMU emulation patches, another try |
Date: |
Wed, 01 Jun 2011 11:49:57 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 |
On 05/31/2011 06:38 PM, Eduard - Gabriel Munteanu wrote:
> Hi,
>
> Again, sorry for taking so long, but I just don't send stuff without looking
> through it. This is meant to go into Michael's PCI branch, if it does.
>
> Some of the changes include:
> - some fixes (one thanks to David Gibson) and cleanups
> - macro magic for exporting clones of the DMA interface (e.g.
> pci_memory_read()); I hope it isn't too much a stretch
> - we use pci_memory_*() in most places where PCI devices are involved now
> - luckily we don't need unaligned accesses anymore
> - some attempt at signaling target aborts, but it doesn't seem like that
> stuff is completely implemented in the PCI layer / devices
> - PCI ids are defined in hw/amd_iommu.c until they get merged into Linux
>
> Also, I can't answer every request that the API is extended for doing this and
> that more comfortably. I understand there may be corner cases, but may I
> suggest merging it (maybe into a separate branch related to mst's pci) so that
> everybody can deal with it? This is still labeled RFC, but if you think it's
> ready it can be merged.
>
> I hope most of the important issues have been dealt with. I'll post the
> SeaBIOS
> patches soon (though I think you can give it a spin with the old ones, if you
> need). I'll also take care of submitting PCI ids to be merged into Linux.
>
> In any case, let me know what you think. I hope I didn't forget to Cc someone.
In order to move the discussion along productively, please have a look at
git://repo.or.cz/qemu/rth.git axp-iommu-1
which is based on your previous patch set.
There's stuff in there that's not 100% relevant to the discussion, but
these two commits:
0652a74 target-alpha: Implement iommu translation for Typhoon.
db50b11 DMA: Use an void* opaque value, rather than upcasting from qdev.
are exactly what I'm interested in discussing.
r~
- [Qemu-devel] [RFC PATCH 04/13] ide: use the DMA memory access interface for PCI IDE controllers, (continued)
- [Qemu-devel] [RFC PATCH 04/13] ide: use the DMA memory access interface for PCI IDE controllers, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 05/13] rtl8139: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 06/13] eepro100: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 07/13] ac97: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 08/13] es1370: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 09/13] e1000: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 10/13] lsi53c895a: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 11/13] pcnet: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 12/13] usb-uhci: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 13/13] usb-ohci: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- Re: [Qemu-devel] [RFC PATCH 00/13] AMD IOMMU emulation patches, another try,
Richard Henderson <=