Re: [Qemu-devel] [PATCH] Fix build on FreeBSD

[Nathan Whitehorn]

On 06/02/11 10:01, Andreas Färber wrote:
> Am 31.05.2011 um 16:57 schrieb Nathan Whitehorn:
>
> > Add some includes required to build qemu on FreeBSD.
>
> Missing Sob.

Oops, I'll resubmit.

> > ---
> > bsd-user/syscall.c |    2 ++
> > iohandler.c        |    1 +
> > os-posix.c         |    4 ++++
> > 3 files changed, 7 insertions(+), 0 deletions(-)
> [...]
> > diff --git a/iohandler.c b/iohandler.c
> > index 2b82421..7266aca 100644
> > --- a/iohandler.c
> > +++ b/iohandler.c
> > @@ -29,6 +29,7 @@
> >
> > #ifndef _WIN32
> > #include <sys/wait.h>
> > +#include <signal.h>
> > #endif
> >
> > typedef struct IOHandlerRecord {
>
> This is independent of the other BSD issues (that I cannot judge) and 
> affects Darwin and Haiku as well. Did you check that with your patch 
> Win32 does not need the header?
>
> Alexandre (cc'ed) posted a slightly different patch, adding it in 
> qemu-common.h instead.

Ah, that's fine then. I have no idea about Win32, I just know it won't 
compile on FreeBSD without it, since it hasn't been included yet as a 
side effect.
-Nathan