Hi,
On 06/01/2011 02:32 PM, Gerd Hoffmann wrote:
On 05/31/11 11:35, Hans de Goede wrote:
So that we don't retry to open it every 2 seconds flooding stderr with
error messages.
The polling here is done intentionally, so the devices catched by the
filter show up in the guest automagically as soon as they are plugged
in. Just zapping the filter on failure isn't the right thing to do here.
Note I'm zapping the filter when we fail to open the device, not when it
is not present. This can happen for example when the qemu user does not
have rights on the usbfs device node.
It seems better to me to print the relevant error once, and then require
the user to redo the usb_add / device_add if necessary, then to flood
the monitor with repeating the same error every 2 seconds.