qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 23/31] usb-linux: Don't try to open the same device


From: Gerd Hoffmann
Subject: [Qemu-devel] [PATCH 23/31] usb-linux: Don't try to open the same device twice
Date: Mon, 6 Jun 2011 14:39:14 +0200

From: Hans de Goede <address@hidden>

If a user wants to redirect 2 identical usb sticks, in theory this is
possible by doing:
usb_add host:1234:5678
usb_add host:1234:5678

But this will lead to us trying to open the first stick twice, since we
don't break the loop after having found a match in our filter list, so the next'
filter list entry will result in us trying to open the same device again.

Fix this by adding the missing break.

Signed-off-by: Gerd Hoffmann <address@hidden>
---
 usb-linux.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index 82c1e7d..1208a97 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -1672,6 +1672,7 @@ static int usb_host_auto_scan(void *opaque, int bus_num, 
int addr, char *port,
         DPRINTF("husb: auto open: bus_num %d addr %d\n", bus_num, addr);
 
         usb_host_open(s, bus_num, addr, port, product_name, speed);
+        break;
     }
 
     return 0;
-- 
1.7.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]