Re: [Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 06/07/2011 09:51 AM, Markus Armbruster wrote:
>>> >  diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c
>>> >  index 6f34159..a193caa 100644
>>> >  --- a/hw/spapr_vio.c
>>> >  +++ b/hw/spapr_vio.c
>>> >  @@ -52,6 +52,10 @@
>>> >    static struct BusInfo spapr_vio_bus_info = {
>>> >        .name       = "spapr-vio",
>>> >        .size       = sizeof(VIOsPAPRBus),
>>> >  +    .props = (Property[]) {
>>> >  +        DEFINE_PROP_UINT32("irq", VIOsPAPRDevice, vio_irq_num, 0), \
>>> >  +        DEFINE_PROP_END_OF_LIST(),
>>> >  +    },
>>> >    };
>>
>> Out of this patch's scope, but I need to ask anyway: do devices on a
>> spapr-vio bus have a unique address?  If yes, what is it?
>
> That would be the "reg" value in DEFINE_SPAPR_PROPERTIES (patch 2).  I
> didn't make it a bus property because the default values varies
> according to the device type.

Hmm.  Explain that in a comment where the bus property would go?

>> Is it okay to share interrupts?
>
> Seems to work. :)

Fair enough.