Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script

[Peter Maydell]

On 8 June 2011 15:10, Jan Kiszka <address@hidden> wrote:
> --- /dev/null
> +++ b/scripts/update-linux-headers.sh
> @@ -0,0 +1,55 @@
> +#!/bin/sh -e
> +#

> +if [ -z "$output" ]; then
> +    output=$PWD
> +fi

> +    mkdir -p $output/linux-headers/asm-$arch

This script is rather lacking in quoting throughout. As a random
example, this looks like it will break if you run the script from
a directory with a space in the path.

> +tmpdir=$TMPDIR/.tmp-hdrs-$$

Better (safer) to use mktemp, I think.

> if [ -z "$linux" -o ! -d "$linux" ]; then

test -o is obsolescent in POSIX; use
 if [ -z "$linux" ] || ! [ -d "$linux" ] ; then
instead.

-- PMM