[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 01/12] qdev: Add support for property type bo
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 01/12] qdev: Add support for property type bool |
Date: |
Thu, 09 Jun 2011 16:45:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> VMState supports the type bool but qdev instead supports bit, backed by
> uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool().
>
> Since, e.g., enabled=on does not look nice, parse/print "yes" and "no".
The difference between bool and bit properties is implementation detail.
Using "on/off" for one, and "yes/no" for the other is a gratuitously
inconsistent user interface.
For what it's worth, "on" doesn't look nice for many bit properties
either.
Options:
1. Live with the inconsistent user interface
1. Stick to on/off ugly or not
3. Switch to yes/no and deprecate on/off
Opinions?
- Re: [Qemu-devel] [RFC v4 04/12] isa: Allow to un-assign I/O ports, (continued)
- Re: [Qemu-devel] [RFC v4 04/12] isa: Allow to un-assign I/O ports, Gleb Natapov, 2011/06/12
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Gerd Hoffmann, 2011/06/09
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Andreas Färber, 2011/06/09
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Gerd Hoffmann, 2011/06/09
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Andreas Färber, 2011/06/09
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Gerd Hoffmann, 2011/06/09
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Markus Armbruster, 2011/06/09
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Andreas Färber, 2011/06/12
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Markus Armbruster, 2011/06/09
- Re: [Qemu-devel] [RFC v4 03/12] isa: Provide set_state callback, Andreas Färber, 2011/06/12
- Re: [Qemu-devel] [PATCH v4 01/12] qdev: Add support for property type bool,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v4 01/12] qdev: Add support for property type bool, Andreas Färber, 2011/06/12
- Re: [Qemu-devel] [RFC v4 00/12] ISA reconfigurability v4, Blue Swirl, 2011/06/13
- Re: [Qemu-devel] [RFC v4 00/12] ISA reconfigurability v4, Andreas Färber, 2011/06/13
- Re: [Qemu-devel] [RFC v4 00/12] ISA reconfigurability v4, Blue Swirl, 2011/06/15
- [Qemu-devel] [RFC v3 10/11] qdev: Add helpers for reading properties, Andreas Färber, 2011/06/07
- [Qemu-devel] [RFC v3 11/11] prep: Add pc87312 Super I/O emulation, Andreas Färber, 2011/06/07