qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2][ 05/21] qapi: add qapi-types.py code generat


From: Michael Roth
Subject: Re: [Qemu-devel] [PATCH v2][ 05/21] qapi: add qapi-types.py code generator
Date: Thu, 09 Jun 2011 10:28:16 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10

On 06/09/2011 10:05 AM, Luiz Capitulino wrote:
On Fri,  3 Jun 2011 17:33:03 -0500
Michael Roth<address@hidden>  wrote:

This is the code generator for qapi types. It will generation the
following files:

   $(prefix)qapi-types.h - C types corresponding to types defined in
                           the schema you pass in
   $(prefix)qapi-types.c - Cleanup functions for the above C types

The $(prefix) is used to as a namespace to keep the generated code from
one schema/code-generation separated from others so code and be
generated from multiple schemas with clobbering previously created code.

This is generating code that can't be built, because the qapi modules are
being added after the code generator. I think we should do the opposite:
the qapi modules have to be introduced before anything which uses them.

Makes sense.


Also note that a patch adding a module should also update the Makefile, so
that the module can be built.

Ok, I'll try to do this for the re-spin.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]