Re: [Qemu-devel] [PATCH v2] Darwin: Fix compilation warning regarding the deprecated daemon() function

[Andreas Färber]

Am 09.06.2011 um 20:47 schrieb Andreas Färber:

> Am 07.06.2011 um 05:34 schrieb Alexandre Raymond:
>
> > Changes since v1: create a wrapper function named qemu_daemon() in  
> > oslib-posix.c
> > instead of putting the OS specific workaround in qemu-nbd.c directly.
> >
> > On OSX >= 10.5, daemon() is deprecated, resulting in the following  
> > warning:
> > ----8<----
> > qemu-nbd.c: In function ‘main’:
> > qemu-nbd.c:371: warning: ‘daemon’ is deprecated (declared at /usr/ 
> > include/stdlib.h:289)
> > ----8<----
> >
> > The following trick, used in mDNSResponder, takes care of this  
> > warning:
> > http://www.opensource.apple.com/source/mDNSResponder/mDNSResponder-258.18/mDNSPosix/PosixDaemon.c
> >
> > On OSX, it temporarily renames the daemon() function before  
> > including stdlib.h
> > and declares it manually as an extern function. This way, the  
> > compiler does not
> > see the declaration from stdlib.h and thus does not display the  
> > warning.
> >
> > Signed-off-by: Alexandre Raymond <address@hidden>
>
> Acked-by: Andreas Färber <address@hidden>
>
> Blue, do you want this to go through the cocoa queue (please ack  
> then) or do you want to apply this directly?
>
> I have two further issues on my radar, 1) Alexandre's handleEvent:  
> warning and 2) the big sigfd issue, and would then send a pull  
> request.

> > diff --git a/oslib-posix.c b/oslib-posix.c
> > index 7bc5f7c..5392e25 100644
> > --- a/oslib-posix.c
> > +++ b/oslib-posix.c
> > @@ -26,11 +26,26 @@
> > * THE SOFTWARE.
> > */
> >
> > +/* The following block of code temporarily renames the daemon()  
> > function so the

This line had a trailing whitespace btw.

Andreas