[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/13] vmware-vga: Use cpu_register_physical_mem
From: |
andrzej zaborowski |
Subject: |
Re: [Qemu-devel] [PATCH 09/13] vmware-vga: Use cpu_register_physical_memory_log for dirty log enabling |
Date: |
Thu, 16 Jun 2011 02:06:53 +0200 |
On 14 June 2011 18:53, Jan Kiszka <address@hidden> wrote:
> This eliminates the last user of vga_dirty_log_start/start.
>
> CC: Andrzej Zaborowski <address@hidden>
> Signed-off-by: Jan Kiszka <address@hidden>
Reviewed-by: Andrzej Zaborowski <address@hidden>
> ---
> hw/vmware_vga.c | 12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
> index c20f154..7cb0c28 100644
> --- a/hw/vmware_vga.c
> +++ b/hw/vmware_vga.c
> @@ -828,9 +828,13 @@ static void vmsvga_value_write(void *opaque, uint32_t
> address, uint32_t value)
> s->vga.invalidate(&s->vga);
> if (s->enable) {
> s->fb_size = ((s->depth + 7) >> 3) * s->new_width * s->new_height;
> - vga_dirty_log_stop(&s->vga);
> - } else {
> - vga_dirty_log_start(&s->vga);
> + cpu_register_physical_memory_log(s->vram_base, s->vga.vram_size,
> + s->vga.vram_offset | IO_MEM_RAM,
> + 0, false);
> + } else if (s->vram_base) {
> + cpu_register_physical_memory_log(s->vram_base, s->vga.vram_size,
> + s->vga.vram_offset | IO_MEM_RAM,
> + 0, true);
> }
> break;
>
> @@ -1011,8 +1015,6 @@ static void vmsvga_reset(DeviceState *dev)
> break;
> }
> s->syncing = 0;
> -
> - vga_dirty_log_start(&s->vga);
> }
>
> static void vmsvga_invalidate_display(void *opaque)
> --
> 1.7.1
>
>
>
- [Qemu-devel] [PATCH 00/13] vga: dirty log cleanup, more linear mapping, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 04/13] vmware-vga: Disable verbose mode, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 06/13] vmware-vga: Eliminate vga_dirty_log_restart, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 13/13] vga: Use linear mapping + dirty logging in chain 4 memory access mode, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 05/13] vmware-vga: Remove dead DIRECT_VRAM mode, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 08/13] vmware-vga: Register reset service, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 09/13] vmware-vga: Use cpu_register_physical_memory_log for dirty log enabling, Jan Kiszka, 2011/06/14
- Re: [Qemu-devel] [PATCH 09/13] vmware-vga: Use cpu_register_physical_memory_log for dirty log enabling,
andrzej zaborowski <=
- [Qemu-devel] [PATCH 07/13] vmware_vga: Do not enable dirty logging when in SVGA mode, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 02/13] vga-pci: Use cpu_register_physical_memory_log for dirty log enabling, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 03/13] cirrus-vga: Drop redundant vga_dirty_log_start, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 12/13] vga: Move vga_sync_dirty_bitmap, Jan Kiszka, 2011/06/14
- [Qemu-devel] [PATCH 11/13] vga: Refactor lfb_vram_mapped to vga_mem_mapped, Jan Kiszka, 2011/06/14