qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params" node
Date: Sat, 25 Jun 2011 23:09:18 +0100

On 24 June 2011 17:35,  <address@hidden> wrote:
> +out_error:
> +    qemu_free(blkdev->params);
> +    qemu_free(blkdev->mode);
> +    qemu_free(blkdev->type);
> +    qemu_free(blkdev->dev);
> +    qemu_free(blkdev->devtype);
> +    return -1;

It occured to me that could result in a double-free if it's
possible to call init again (or to call free) after the init
routine has returned failure. I don't know enough about the
Xen device lifecycle to know if that's possible, though -- is it?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]