Re: [Qemu-devel] [PATCH] qxl: move qemu_spice_add_memslot call out of qxl_add_memslot

[Alon Levy]

On Thu, Jul 07, 2011 at 09:39:34AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >-static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t 
> >delta)
> >+static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t 
> >delta,
> >+                            QXLDevMemSlot *memslot)
> 
> >-        qxl_add_memslot(d, val, 0);
> >+        qxl_add_memslot(d, val, 0,&memslot);
> >+        qemu_spice_add_memslot(&d->ssd,&memslot);
> 
> Do we still need this and the simliar patches?  Given that we don't
> call qemu_spice_add_memslot() from another thread any more we could
> just pass in a async flag to qxl_add_memslot().

I will. The most changes needed are to split the part after calling worker to a 
complete call,
I'm storing the io data inside PCIQXLDevice.

> 
> cheers,
>   Gerd
> 
>