Re: [Qemu-devel] [PATCH v2] qxl: async I/O

[Gerd Hoffmann]

> btw, I'm looking at "#if.*MINOR" code like
>
>   #if SPICE_INTERFACE_CORE_MINOR>= 3
>
> (ui/spice-core.c)
>
> Shouldn't that be checking the MAJOR as well?

major changing means a incompatible change.  I doubt we ever will do 
that.  But if you feel better checking that it probably should just be a

#if SPICE_INTERFACE_CORE_MAJOR != 1
#error incompatible spice core interface
#endif

at the top of the file.

cheers,
  Gerd