[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API
From: |
malc |
Subject: |
Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API |
Date: |
Tue, 12 Jul 2011 02:03:31 +0400 (MSD) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Mon, 11 Jul 2011, Avi Kivity wrote:
> On 07/11/2011 04:42 AM, Anthony Liguori wrote:
> > On 07/10/2011 03:33 PM, malc wrote:
> > > On Sun, 10 Jul 2011, Avi Kivity wrote:
> > >
> > > > fixes BAR sizing as well.
> > >
> > > I find this patch disgusting, the read and write handlers in particular.
> >
> > Shouldn't it be possible to do something like:
> >
> > typedef struct OldMemoryRegionOps {
> > MemoryRegionOps parent_ops;
> > CPUReadMemoryFunc *readfn[3];
> > CPUWriteMemoryFunc *writefn[3];
> > void *opaque;
> > } OldMemoryRegionOps;
> >
> > That should allow old-style implementations to be converted without
> > introducing trampoline functions everywhere.
>
> Here's a new version:
This one looks acceptable[1], original submission said:
"fixes BAR sizing as well." what was wrong with it?
[..snip..]
P.S. Sans minor inconsistency with trailing commas.
--
mailto:address@hidden
- [Qemu-devel] [RFC v3 18/56] pci: add API to get a BAR's mapped address, (continued)
- [Qemu-devel] [RFC v3 18/56] pci: add API to get a BAR's mapped address, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 03/56] memory: merge adjacent segments of a single memory region, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 21/56] cirrus: simplify mmio BAR access functions, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 02/56] memory: implement dirty tracking, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 11/56] pc: grab system_memory, Avi Kivity, 2011/07/10
- [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 17/56] usb-ohci: convert to MemoryRegion, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 08/56] memory: I/O address space support, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 07/56] memory: late initialization of ram_addr, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 16/56] sysbus: add MemoryRegion based memory management API, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 06/56] memory: rename MemoryRegion::has_ram_addr to ::terminates, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 12/56] pc: convert pc_memory_init() to memory API, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 19/56] vmsvga: don't remember pci BAR address in callback any more, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 10/56] ioport: register ranges by byte aligned addresses always, Avi Kivity, 2011/07/10
[Qemu-devel] [RFC v3 53/56] pci: convert pci rom to memory API, Avi Kivity, 2011/07/10