qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] exec.c: Use ram_addr_t in cpu_physical_memo


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/5] exec.c: Use ram_addr_t in cpu_physical_memory_rw(...).
Date: Fri, 15 Jul 2011 16:46:23 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Mnenhy/0.8.3 Thunderbird/3.1.10

On 07/15/2011 04:32 PM, Anthony PERARD wrote:
As the variable pd and addr1 inside the function cpu_physical_memory_rw
are mean to handle a RAM address, they should be of the ram_addr_t type
instead of unsigned long.

Signed-off-by: Anthony PERARD<address@hidden>
---
  exec.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/exec.c b/exec.c
index c0673c2..4220d45 100644
--- a/exec.c
+++ b/exec.c
@@ -3858,7 +3858,7 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, 
uint8_t *buf,
      uint8_t *ptr;
      uint32_t val;
      target_phys_addr_t page;
-    unsigned long pd;
+    ram_addr_t pd;
      PhysPageDesc *p;

      while (len>  0) {
@@ -3898,7 +3898,7 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, 
uint8_t *buf,
                      l = 1;
                  }
              } else {
-                unsigned long addr1;
+                ram_addr_t addr1;
                  addr1 = (pd&  TARGET_PAGE_MASK) + (addr&  ~TARGET_PAGE_MASK);
                  /* RAM case */
                  ptr = qemu_get_ram_ptr(addr1);

Acked-by: Paolo Bonzini <address@hidden>

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]