[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-9p: Fix syntax error in debug code
From: |
Aneesh Kumar K.V |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-9p: Fix syntax error in debug code |
Date: |
Wed, 20 Jul 2011 15:14:26 +0530 |
User-agent: |
Notmuch/0.5-318-g52e4ded (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) |
On Wed, 20 Jul 2011 08:27:28 +0200, Stefan Weil <address@hidden> wrote:
> This error was reported by cppcheck:
>
> qemu/hw/9pfs/virtio-9p-debug.c:342:
> error: Invalid number of character ({) when these macros are defined:
> 'DEBUG_DATA'.
>
> Cc: Aneesh Kumar K.V <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/9pfs/virtio-9p-debug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p-debug.c b/hw/9pfs/virtio-9p-debug.c
> index 4636ad5..96925f0 100644
> --- a/hw/9pfs/virtio-9p-debug.c
> +++ b/hw/9pfs/virtio-9p-debug.c
> @@ -295,7 +295,7 @@ static void pprint_data(V9fsPDU *pdu, int rx, size_t
> *offsetp, const char *name)
>
> if (rx) {
> count = pdu->elem.in_num;
> - } else
> + } else {
> count = pdu->elem.out_num;
> }
>
Applied.
We also need to update virtio-9p-debug w.r.t the new co-routine
series. With co-routine we can have multiple 9p handler started
simultaneously.
-aneesh