[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/55] ide/atapi: Track tray open/close state
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 16/55] ide/atapi: Track tray open/close state |
|
Date: |
Tue, 26 Jul 2011 13:59:53 +0200 |
|
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Wed, Jul 20, 2011 at 06:23:50PM +0200, Markus Armbruster wrote:
> We already track it in BlockDriverState since commit 4be9762a. As
> discussed in that commit's message, we should track it in the device
> device models instead, because it's device state.
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>
- [Qemu-devel] [PATCH 00/55] Block layer cleanup & fixes, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 01/55] blockdev: Make eject fail for non-removable drives even with -f, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 06/55] block/raw-win32: Drop disabled code for removable host devices, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 16/55] ide/atapi: Track tray open/close state, Markus Armbruster, 2011/07/20
- Re: [Qemu-devel] [PATCH 16/55] ide/atapi: Track tray open/close state,
Christoph Hellwig <=
- [Qemu-devel] [PATCH 08/55] block: Make BlockDriver method bdrv_eject() return void, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 09/55] block: Don't let locked flag prevent medium load, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 21/55] block: Revert entanglement of bdrv_is_inserted() with tray status, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 27/55] scsi-disk: Switch from BlockDriverState's locked to own tray_locked, Markus Armbruster, 2011/07/20