[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray st
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch |
Date: |
Tue, 26 Jul 2011 15:43:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Christoph Hellwig <address@hidden> writes:
> On Wed, Jul 20, 2011 at 06:24:07PM +0200, Markus Armbruster wrote:
>> When ide-cd is backed by a physical drive, we want the physical tray
>> match the virtual one. To that end, we call bdrv_eject() on guest's
>> load/eject, and bdrv_lock_medium() on guest's prevent/allow removal.
>> But we don't set the initial state on device model init. Fix that.
>>
>> While there, also unlock on device model exit.
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <address@hidden>
>
> But wondering: do you actually use the physical CDROM passthrough?
In my opinion, it's one of the QEMU features friends don't let friends
use. But it's there, I can fix it a little, so I fix it a little. A
wiser man would perhaps close his eyes and move on to fix something more
useful :)
[Qemu-devel] [PATCH 24/55] ide/atapi: Track tray locked state, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 17/55] ide/atapi: Switch from BlockDriverState's tray_open to own, Markus Armbruster, 2011/07/20