[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 20/39] virtio-pci: convert to memory API
Date: Tue, 02 Aug 2011 15:39:53 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110621 Fedora/3.1.11-1.fc15 Thunderbird/3.1.11

On 08/02/2011 12:34 PM, Michael S. Tsirkin wrote:
On Tue, Aug 02, 2011 at 12:17:06PM +0300, Avi Kivity wrote:
>  On 08/01/2011 10:53 PM, Michael S. Tsirkin wrote:
>  >>
>  >>
>  >>   Just because a memory region becomes visible to the cpu is no reason
>  >>   to have a callback.  From the device perspective, it can't tell that
>  >>   it happened.
>  >
>  >BTW this is what qxl does, too, conceptually: on config writes, it peeks
>  >at the bar to detect whether that got unmapped.
>  Can you elaborate?  why?  what does it do?

Disables vga mapping when it sees io has been disabled.
What it really should do is check the io enable bit I think ...

     pci_default_write_config(d, address, val, len);
     if (vga->map_addr&&  qxl->pci.io_regions[0].addr == -1) {
         vga->map_addr = 0;

If the memory is not visible to the guest, logging has no effect.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]