[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read |
Date: |
Wed, 3 Aug 2011 10:49:04 +0200 |
In fact, if the HBA's transfer_data callback goes on with scsi_req_continue
the request will be completed successfully instead of showing a failure.
It can even cause a segmentation fault.
An easy way to trigger it is "eject -f cd" during installation (during media
test if the installer does something like that).
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi-disk.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index f42a5d1..814bf74 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -217,9 +217,6 @@ static int scsi_handle_rw_error(SCSIDiskReq *r, int error,
int type)
bdrv_mon_event(s->bs, BDRV_ACTION_STOP, is_read);
vm_stop(VMSTOP_DISKFULL);
} else {
- if (type == SCSI_REQ_STATUS_RETRY_READ) {
- scsi_req_data(&r->req, 0);
- }
switch (error) {
case ENOMEM:
scsi_command_complete(r, CHECK_CONDITION,
--
1.7.6
- [Qemu-devel] [PATCH 00/16] SCSI sense and target request overhaul, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 02/16] vscsi: always use get_sense, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 03/16] scsi: pass status when completing, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 06/16] scsi: move request-related callbacks from SCSIDeviceInfo to SCSIReqOps, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 05/16] scsi: introduce SCSIReqOps, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 08/16] scsi: introduce SCSICommand, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 07/16] scsi: pass cdb already to scsi_req_new, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 11/16] scsi: move handling of REPORT LUNS and invalid LUNs to common code, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 13/16] scsi: add a bunch more common sense codes, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 12/16] scsi: move handling of REQUEST SENSE to common code, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 14/16] scsi: add support for unit attention conditions, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 09/16] scsi: push lun field to SCSIDevice, Paolo Bonzini, 2011/08/03