[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/16] scsi: move sense handling to generic code
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 04/16] scsi: move sense handling to generic code |
Date: |
Wed, 3 Aug 2011 18:34:57 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Wed, Aug 03, 2011 at 10:49:07AM +0200, Paolo Bonzini wrote:
> With this patch, sense data is stored in the generic data structures
> for SCSI devices and requests. The SCSI layer takes care of storing
> sense data in the SCSIDevice for the subsequent REQUEST SENSE command.
>
> At the same time, get_sense is removed and scsi_req_get_sense can use
> an entirely generic implementation.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Looks sensible to me,
Reviewed-by: Christoph Hellwig <address@hidden>
- [Qemu-devel] [PATCH 12/16] scsi: move handling of REQUEST SENSE to common code, (continued)
- [Qemu-devel] [PATCH 12/16] scsi: move handling of REQUEST SENSE to common code, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 14/16] scsi: add support for unit attention conditions, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 09/16] scsi: push lun field to SCSIDevice, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 15/16] scsi: report unit attention on reset, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 10/16] scsi: move request parsing to common code, Paolo Bonzini, 2011/08/03
- [Qemu-devel] [PATCH 04/16] scsi: move sense handling to generic code, Paolo Bonzini, 2011/08/03
- Re: [Qemu-devel] [PATCH 04/16] scsi: move sense handling to generic code,
Christoph Hellwig <=
- [Qemu-devel] [PATCH 16/16] scsi: add special traces for common commands, Paolo Bonzini, 2011/08/03
- Re: [Qemu-devel] [PATCH 00/16] SCSI sense and target request overhaul, Anthony Liguori, 2011/08/12