Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in bl

From:	Markus Armbruster
Subject:	Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h
Date:	Thu, 04 Aug 2011 20:22:15 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> On Wed,  3 Aug 2011 15:08:19 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Device models should be able to use it without an unclean include of
>> block_int.h.
>
> Nitpick: I'd do the prototype move after patch 38/45 and include the
> block_int.h removal in the patch you're trimming block_int.h includes.

Care to explain why?

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-devel] [PATCH v2 18/45] block: Drop medium lock tracking, ask device models instead, (continued)
- [Qemu-devel] [PATCH v2 18/45] block: Drop medium lock tracking, ask device models instead, Markus Armbruster, 2011/08/03
- [Qemu-devel] [PATCH v2 35/45] block: Clean up remaining users of "removable", Markus Armbruster, 2011/08/03
  - Re: [Qemu-devel] [PATCH v2 35/45] block: Clean up remaining users of "removable", Luiz Capitulino, 2011/08/04
- [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block, Markus Armbruster, 2011/08/03
  - Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block, Luiz Capitulino, 2011/08/04
- [Qemu-devel] [PATCH v2 23/45] scsi-disk: Fix START_STOP to fail when it can't eject, Markus Armbruster, 2011/08/03
  - Re: [Qemu-devel] [PATCH v2 23/45] scsi-disk: Fix START_STOP to fail when it can't eject, Hannes Reinecke, 2011/08/04
    - Re: [Qemu-devel] [PATCH v2 23/45] scsi-disk: Fix START_STOP to fail when it can't eject, Markus Armbruster, 2011/08/04
- [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h, Markus Armbruster, 2011/08/03
  - Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h, Luiz Capitulino, 2011/08/04
    - Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h, Markus Armbruster <=
    - Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h, Luiz Capitulino, 2011/08/04
- Re: [Qemu-devel] [PATCH v2 00/45] Block layer cleanup & fixes, Avi Kivity, 2011/08/04

Prev by Date: Re: [Qemu-devel] read-only IDE drives in qemu
Next by Date: Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h
Previous by thread: Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h
Next by thread: Re: [Qemu-devel] [PATCH v2 40/45] block: Declare qemu_blockalign() in block.h, not block_int.h
Index(es):
- Date
- Thread