Re: [Qemu-devel] [PATCH 1/2] ptimer: move declarations to ptimer.h

[Anthony Liguori]

On 08/06/2011 10:17 AM, Paolo Bonzini wrote:
> On 08/05/2011 05:56 PM, Anthony Liguori wrote:
> > On 08/02/2011 06:47 AM, Paolo Bonzini wrote:
> > > Since the next patch will move VMState declarations for ptimers out
> > > of hw/hw.h, prepare a place for them.
> > >
> > > Signed-off-by: Paolo Bonzini<address@hidden>
> > > ---
> > > hw/arm_timer.c | 1 +
> > > hw/etraxfs_timer.c | 1 +
> > > hw/grlib_apbuart.c | 1 +
> > > hw/grlib_gptimer.c | 1 +
> > > hw/lan9118.c | 1 +
> > > hw/leon3.c | 1 +
> > > hw/lm32_timer.c | 1 +
> > > hw/mcf5206.c | 1 +
> > > hw/mcf5208.c | 1 +
> > > hw/milkymist-sysctl.c | 1 +
> > > hw/musicpal.c | 1 +
> > > hw/ptimer.c | 1 +
> > > hw/ptimer.h | 27 +++++++++++++++++++++++++++
> > > hw/sh_timer.c | 1 +
> > > hw/slavio_timer.c | 1 +
> >
> > With this series applied, I get:
> >
> > In file included from /home/anthony/git/qemu/hw/slavio_timer.c:27:0:
> > /home/anthony/git/qemu/hw/ptimer.h:27:33: error: expected ‘=’, ‘,’, ‘;’,
> > ‘asm’ or ‘__attribute__’ before ‘vmstate_ptimer’
> > /home/anthony/git/qemu/hw/slavio_timer.c:338:9: error: ‘vmstate_ptimer’
> > undeclared here (not in a function)
> > make[1]: *** [slavio_timer.o] Error 1
> > make: *** [subdir-sparc-softmmu] Error 2
>
> Never attribute to chance what can be attributed to stupidity. Forgot I
> had configured with --target-list.

It happens :-)

Regards,

Anthony Liguori

> Paolo