qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion.


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion.
Date: Thu, 11 Aug 2011 09:27:53 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0

On 08/11/2011 09:22 AM, Avi Kivity wrote:
On 08/11/2011 01:28 AM, Richard Henderson wrote:
      }
  };

+static const MemoryRegionOps cs_ioport_ops = {
+    .read = cs_read,
+    .write = cs_write,
+    .impl = {
+        .min_access_size = 1,
+        .max_access_size = 1,
+    }
+};

Should be .valid, not .impl.

.impl means the implementation only supports this access size; emulate other sizes by using a supported size (e.g. crack a 4-byte access into 4 1-byte accesses). .valid means what the device actually supports; if the guest uses another size something bus-defined happens.

Oh, the standard qemu implementation auto-cracks, so .impl is correct.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]