qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Rename dma.c and its contents to reflect its IS


From: malc
Subject: Re: [Qemu-devel] [PATCH] Rename dma.c and its contents to reflect its ISA specific nature
Date: Mon, 15 Aug 2011 11:39:29 +0400 (MSD)
User-agent: Alpine 2.00 (LNX 1167 2008-08-23)

On Mon, 15 Aug 2011, David Gibson wrote:

> hw/dma.c does not contain code generally relevant to drivers accessing
> system memory.  In particular, it has no connection to dma.h, which does
> have headers pertaining to the generally useful dma functions in
> dma-helpers.c.  Rather, it is code specific to emulating the legacy
> ISA-style DMA controllers found on some platforms.
> 
> To address this misleading naming, this function renames hw/dma.c to
> hw/isa-dma.c, and renames exported functions within it as s/DMA/isa_dma/.
> Makefiles and configure script are updated accordingly.
> 

It has been done before btw:
http://repo.or.cz/w/qemu/malc.git/shortlog/refs/heads/redma1
http://repo.or.cz/w/qemu/malc.git/shortlog/refs/heads/redma

With a slightly more consistent naming (i8257_ instead of isa_dma_)
Not that i object to this.

[..snip..]

-- 
mailto:address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]